Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle external bigquery relations (#791) #828

Merged
merged 5 commits into from
Jul 11, 2018

Conversation

beckjake
Copy link
Contributor

@beckjake beckjake commented Jul 6, 2018

Add support to the BigQuery adapter for the presence of external data sources, fixing #791

dbt/logger.py Outdated
@@ -1,5 +1,6 @@
import dbt.compat
import logging
import logging.handlers
Copy link
Contributor Author

@beckjake beckjake Jul 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took me a while to figure out why this is failing intermittently for me - it's because in normal operation something else imports logging.handlers and modules are singletons so everyone accessing logging has access to logging.handlers once it's been imported.

However, in some test runs for whatever reason, dbt.logger.initialize_logger executes before whatever other module that's loading does import logging.handlers, and so it doesn't see logging.handlers and fails.

@beckjake beckjake requested a review from drewbanin July 10, 2018 17:17
@beckjake beckjake merged commit 40afdf4 into development Jul 11, 2018
@beckjake beckjake deleted the external-bigquery-relation branch July 11, 2018 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants